Use locales on mailer views #5679
Closed
+34
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The other day I was trying to internationalizate mailers on my application and ended up copying the views just to translate the mails content So, that is why I think it would be nice to hace the local keys by default
|
@JuanVqz thank for the PR but we don't maintain translations in Devise. You can use https://github.com/devise-i18n/devise-i18n for that or just copy these mailer views into your app and do it there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The other day I was trying to internationalize mailers on my application. I ended up copying the views to translate the mail content, which could be done by changing the content in the local (en.yml)file.
So, that is why I think it would be nice to have the I18n keys instead of the plain text in the mailers