Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make possible to use the Wrappers API to define attributes for the components #997

Merged
merged 35 commits into from
Mar 17, 2014
Merged

Make possible to use the Wrappers API to define attributes for the components #997

merged 35 commits into from
Mar 17, 2014

Commits on Mar 10, 2014

  1. Deal only with objets in the Wrapper API

    @rafaelfranca
    rafaelfranca committed Mar 10, 2014
    Configuration menu
    Copy the full SHA
    8268412 View commit details
    Browse the repository at this point in the history

  2. Component alwyas respond to render now

    @rafaelfranca
    rafaelfranca committed Mar 10, 2014
    Configuration menu
    Copy the full SHA
    7a167ca View commit details
    Browse the repository at this point in the history

  3. Allow the component to render itself

    @rafaelfranca
    rafaelfranca committed Mar 10, 2014
    Configuration menu
    Copy the full SHA
    fa061b6 View commit details
    Browse the repository at this point in the history

  4. Add test case for the feature of applying attributes in the wrapper API

    @rafaelfranca
    rafaelfranca committed Mar 10, 2014
    Configuration menu
    Copy the full SHA
    95da393 View commit details
    Browse the repository at this point in the history

  5. Store the wrapper API attributes in the leaves

    @rafaelfranca
    rafaelfranca committed Mar 10, 2014
    Configuration menu
    Copy the full SHA
    dda2006 View commit details
    Browse the repository at this point in the history

  6. Pass the context when rendering the component

    @rafaelfranca
    rafaelfranca committed Mar 10, 2014
    Configuration menu
    Copy the full SHA
    645988a View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2014

  1. Options should be always a hash

    @rafaelfranca
    rafaelfranca committed Mar 11, 2014
    Configuration menu
    Copy the full SHA
    6976fba View commit details
    Browse the repository at this point in the history

  2. Merge the context options with the input options

    @rafaelfranca
    rafaelfranca committed Mar 11, 2014
    Configuration menu
    Copy the full SHA
    df47a85 View commit details
    Browse the repository at this point in the history

  3. Accept options in label component too

    @rafaelfranca
    rafaelfranca committed Mar 11, 2014
    Configuration menu
    Copy the full SHA
    51bdd20 View commit details
    Browse the repository at this point in the history

  4. Test with label_input too

    @rafaelfranca
    rafaelfranca committed Mar 11, 2014
    Configuration menu
    Copy the full SHA
    93161d7 View commit details
    Browse the repository at this point in the history

  5. Test data attributes in the DSL

    @rafaelfranca
    rafaelfranca committed Mar 11, 2014
    Configuration menu
    Copy the full SHA
    d821015 View commit details
    Browse the repository at this point in the history

  6. Make context optional 

    We plan to make it required in the future but it is optional now to make
easier to implement backwards compatibility
    @rafaelfranca
    rafaelfranca committed Mar 11, 2014
    Configuration menu
    Copy the full SHA
    44f22ca View commit details
    Browse the repository at this point in the history

  7. Deprecate component methods without the context argument 

    Only users that defines custom inputs will see this deprecation.
    @rafaelfranca
    rafaelfranca committed Mar 11, 2014
    Configuration menu
    Copy the full SHA
    9e3aae1 View commit details
    Browse the repository at this point in the history

  8. Extract the deprecation message to avoid duplication

    @rafaelfranca
    rafaelfranca committed Mar 11, 2014
    Configuration menu
    Copy the full SHA
    6186512 View commit details
    Browse the repository at this point in the history

  9. Remove duplication at the deprecated methods

    @rafaelfranca
    rafaelfranca committed Mar 11, 2014
    Configuration menu
    Copy the full SHA
    ed18620 View commit details
    Browse the repository at this point in the history

  10. Extract the wrapper options merge behavior to their own module 

    This make easier to share the same behavior between all the components
    @rafaelfranca
    rafaelfranca committed Mar 11, 2014
    Configuration menu
    Copy the full SHA
    3992cfc View commit details
    Browse the repository at this point in the history

  11. Move the context check down to the method

    @rafaelfranca
    rafaelfranca committed Mar 11, 2014
    Configuration menu
    Copy the full SHA
    4a13b2f View commit details
    Browse the repository at this point in the history

  12. Add link to pull requests in the deprecation message

    @rafaelfranca
    rafaelfranca committed Mar 11, 2014
    Configuration menu
    Copy the full SHA
    135465f View commit details
    Browse the repository at this point in the history

  13. Whitespaces

    @rafaelfranca
    rafaelfranca committed Mar 11, 2014
    Configuration menu
    Copy the full SHA
    e9384fb View commit details
    Browse the repository at this point in the history

  14. Define merge_wrapper_options in Base instead in a Helper 

    Helpers are related to HTML attributes. merge_wrapper_options is not
related to HTML
    @rafaelfranca
    rafaelfranca committed Mar 11, 2014
    Configuration menu
    Copy the full SHA
    58220b2 View commit details
    Browse the repository at this point in the history

  15. Pass the options hash instead of the Leaf object 

    Right now we only care about the options so lets make the code simpler
    @rafaelfranca
    rafaelfranca committed Mar 11, 2014
    Configuration menu
    Copy the full SHA
    15f0101 View commit details
    Browse the repository at this point in the history

  16. Update Many documentation

    @rafaelfranca
    rafaelfranca committed Mar 11, 2014
    Configuration menu
    Copy the full SHA
    0fc7ea8 View commit details
    Browse the repository at this point in the history

  17. Forgot to send some files 💣

    @rafaelfranca
    rafaelfranca committed Mar 11, 2014
    Configuration menu
    Copy the full SHA
    86d0923 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2014

  1. No need to return

    @rafaelfranca
    rafaelfranca committed Mar 14, 2014
    Configuration menu
    Copy the full SHA
    724dff5 View commit details
    Browse the repository at this point in the history

  2. Store the component on the instance 

    We already own the component so we don't need to ask for it again
    @rafaelfranca
    rafaelfranca committed Mar 14, 2014
    Configuration menu
    Copy the full SHA
    3d53595 View commit details
    Browse the repository at this point in the history

  3. Store the wrappers with string keys

    @rafaelfranca
    rafaelfranca committed Mar 14, 2014
    Configuration menu
    Copy the full SHA
    58f14c3 View commit details
    Browse the repository at this point in the history

  4. Add deprecation to CHANGELOG

    @rafaelfranca
    rafaelfranca committed Mar 14, 2014
    Configuration menu
    Copy the full SHA
    be5badb View commit details
    Browse the repository at this point in the history

  5. lookup_action doesn't need to be symbols

    @rafaelfranca
    rafaelfranca committed Mar 14, 2014
    Configuration menu
    Copy the full SHA
    2acb2c1 View commit details
    Browse the repository at this point in the history

  6. Consistent use of the Simple Form name

    @rafaelfranca
    rafaelfranca committed Mar 14, 2014
    Configuration menu
    Copy the full SHA
    464932c View commit details
    Browse the repository at this point in the history

  7. wrapper_options argument is required

    @rafaelfranca
    rafaelfranca committed Mar 14, 2014
    Configuration menu
    Copy the full SHA
    44a5dba View commit details
    Browse the repository at this point in the history

  8. 💄

    @rafaelfranca
    rafaelfranca committed Mar 14, 2014
    Configuration menu
    Copy the full SHA
    266ade3 View commit details
    Browse the repository at this point in the history

  9. Rails 2.3 is dead

    @rafaelfranca
    rafaelfranca committed Mar 14, 2014
    Configuration menu
    Copy the full SHA
    2fa4b7a View commit details
    Browse the repository at this point in the history

  10. Document the options to components

    @rafaelfranca
    rafaelfranca committed Mar 14, 2014
    Configuration menu
    Copy the full SHA
    f14fed4 View commit details
    Browse the repository at this point in the history

  11. Add CHANGELOG entry

    @rafaelfranca
    rafaelfranca committed Mar 14, 2014
    Configuration menu
    Copy the full SHA
    bb2fd3b View commit details
    Browse the repository at this point in the history

  12. Merge remote-tracking branch 'origin/master' into rm-wrapper-classes 

    Conflicts:
	CHANGELOG.md
	lib/simple_form/inputs/boolean_input.rb
    @rafaelfranca
    rafaelfranca committed Mar 14, 2014
    Configuration menu
    Copy the full SHA
    3f47fd0 View commit details
    Browse the repository at this point in the history