Add primary clipboard support for X11 and wayland #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The X11 code already had the functionality. Just didn't expose it. Signed-off-by: Mohammad AlSaleh <[email protected]>
|
PR to add support in |
This was referenced Jan 21, 2024
Closed
|
@hecrj would it be possible to get this fix in? I currently have patches for iced and cosmic-term to get support for primary. |
hecrj
reviewed
Feb 7, 2024
Comment on lines
+90
to
+96
| fn read_primary(&self) -> Option<Result<String, Box<dyn Error>>> { | ||
| None | ||
| } | ||
|
|
||
| fn write_primary(&mut self, _contents: String) -> Option<Result<(), Box<dyn Error>>> { | ||
| None | ||
| } |
There was a problem hiding this comment.
Can we make these available only on Linux?
There was a problem hiding this comment.
Both me and @MoSal created a fix for this, I choose to expose this for unix only, but that is really not very nice to have in the api, since that leaks up all the way through iced to applications trying to use this. So, even if it is more technically correct to only expose this for unix systems, it is much more clean and user friendly with this implementation that have a default implementation that returns None on systems without primary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The X11 code already had the functionality. Just didn't expose it.