Do not generate every token in the specified time-window #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hectorm
requested changes
Apr 17, 2024
hectorm
approved these changes
Apr 19, 2024
|
Merged, thanks! |
|
Thank you for the fast response and the work on this package! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will immidiatly return when a correct token is found. It will also start with comparing the token against the one for the current time, then 1 token before the current time, 1 after, 2 before the current time etc.. until the complete window is compared or a valid token is found.
This should improve performance, because most of the time the current token or the previous token is submitted.
This should fix #487