-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UI] "preview as student" option for teachers #3374
Comments
I can take a look at this! We might have to discuss this a bit before I start working on this:
Maybe the easiest solution: When the teacher selects 'preview as student' we simply add the teacher as a student to their own class. This way everything is automatically rendered as expected. When using the return option 'overview button, close page old' remove the teacher from the class again. |
I think it only makes sense for customized classes (otherwise teachers can just go to /hedy themselves)
That would be lovely! And then add a button or link to go there on the customization page.
Ah yeah that would be an easy way to make it work with not too much effort! But I guess we can also grab the customizations from the database (we already have them to populate all the checkboxes) and use those to render the |
Hi! If this is still open, I would love to be assigned to the issue and work on it! |
@sfayyad yes it is still open! It would be great if we could get this to work but it will be very complex (for front and back-end work), so it might be hard to get started? Maybe you want to pick up an issue with the |
It is complex; however, I have experience working on tasks similar to this, so I believe I can do it! |
Great, if you think you can do this, go for it! We'd be happy to have this feature! |
Hi @jtwaleson! If you are looking for a front-end issue that would add a lot of value, this would be awesome! |
@Felienne I'm going to take a stab at this this week, but it's quite complex and I'll probably have some questions while implementing. First questions: I'm assuming we only want to view the class, and not impersonate any specific students to "see what they see"? So if we write it as a user story it'd be something like: "As a teacher I want to see what a customized class looks like as a student so that I can preview it before I open it up to my students." Is my understanding correct? Do we want to make this fully read-only, or are you able to also run some programs while in "preview mode"? |
Consider these:
Then I would suggest two things to have:
|
Thanks, that's helpful context! I haven't looked at the teacher UI much so far so I'll start by exploring that. |
to find the current way fast, in the class view (create one if none), use "add student" -> "invite by username", write your own username. then you will get notification of the invite and join in upon accepting it. |
As discussed in the meeting today, we would already be happy with just viewing, editing might not even add value, but certainly is not necessary to move this forward for now. |
**Description** Adds a preview mode for teachers, so when they create a class they can view Hedy as if they were a student in this class. Fixes #3374 This is a draft PR, please let me know if this is roughly the right direction. Once we confirm that I'll add: - some tests - make the banner "Preview Mode" look nicer - add translation keys **How to test** Step 1 - Go to For Teacher page. Make sure you have a class with some customizations, like less programs for level 1. Press the "Preview" button. ![Screenshot from 2023-11-29 12-09-57](https://github.com/hedyorg/hedy/assets/1298565/24a1056a-f4e7-4910-a2fa-a37a609a9d39) Step 2 - You should go to /hedy and see the loaded class including a banner "Preview mode". ![Screenshot from 2023-12-18 13-45-47](https://github.com/hedyorg/hedy/assets/1298565/c7ac4b5e-314b-487a-9023-866e63190ba1) The previous version of this design is [here](https://github.com/hedyorg/hedy/assets/1298565/a13ac70d-5524-435a-884a-061164e3160d). Step 3 - You can complete the programs and puzzles as if you were a student Step 4 - When you exit preview mode the banner should disappear and you should go back to the /for-teachers page. **Checklist** Done? Check if you have it all in place using this list: (mark with x if done) - [ ] Contains one of the PR categories in the name - [ ] Describes changes in the format above - [ ] Links to an existing issue or discussion - [ ] Has a "How to test" section
Idea incl level
It will be a lot of work but it would be great if we could have a "view as student" button in the Teacher's UI where a teacher can see exactly what the interface will look like for students (I do this my opening a second browser but that is kind of cumbersome).
This is quite a common features in such teacher tools.
The text was updated successfully, but these errors were encountered: