Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TESTING] Refactor cypress tests #4027

Open
19 tasks done
jpelay opened this issue Feb 10, 2023 · 1 comment
Open
19 tasks done

[TESTING] Refactor cypress tests #4027

jpelay opened this issue Feb 10, 2023 · 1 comment
Assignees
@Annelein
Labels
cypress issues related to Cypress (front-end) testing

Comments

@jpelay
Copy link
Member

jpelay commented Feb 10, 2023 •
edited by Annelein
Loading

As stated by @rix0rrr in #3972 there are two ways in which our tests can be improved:

  1. Test organization: Instead of having defines with a single it we can group different tests under a single define. Saving code and making our test suite more organized.
  2. Selecting HTML elements by ID: Cypress actually prevents against using id or other HTML attributes used in functionality for the tests.

Update: I will change tests bit by bit
@jpelay jpelay mentioned this issue Feb 14, 2023
Closed
@Felienne Felienne moved this to Planned in Hedy organization board Mar 16, 2023
@Felienne Felienne added the cypress issues related to Cypress (front-end) testing label Sep 29, 2023
@Felienne
Copy link
Member

Felienne commented Apr 3, 2024

One more task for @Annelein?

@Annelein Annelein mentioned this issue Apr 10, 2024
Merged
3 tasks
@Annelein Annelein moved this from Planned to In Progress in Hedy organization board Apr 10, 2024
mergify bot pushed a commit that referenced this issue Apr 17, 2024
@Annelein
🧹 Refactor cypress tests (part 1) (#5393)
c64fb12 
Fixes the following tests for #4027 :

- [x] admin page
- [x] explore program page
- [x] feedback
@Annelein Annelein mentioned this issue May 14, 2024
Merged
1 task
mergify bot pushed a commit that referenced this issue May 25, 2024
@Annelein
🧹 Refactor cypress tests (part 2) (#5530)
7edbd2f 
Fixes the following tests for #4027 :

- for-teacher page
   - [x]  class page

The last few tests, which are not in the class page folder. Have only a few edited lines, this is because those were id's changed in class page tests, so I changed all occurrences.

@jpelay I will take care of the conflicts that this will give for #5130
@Annelein Annelein moved this from In Progress to ToBeDiscussed in Hedy organization board May 28, 2024
@Annelein Annelein moved this from ToBeDiscussed to In Progress in Hedy organization board Jun 3, 2024
@Annelein Annelein mentioned this issue Jun 4, 2024
Merged
mergify bot pushed a commit that referenced this issue Jun 18, 2024
@Annelein
🧪 Refactor cypress tests (part 3) (#5592)
9cd260b 
Refactors the entire `for-teacher folder` for #4027 :
- `customize-adventure folder` only data-cy and .it() refactoring

**How to test**
I think the best way is to click around the for-teacher page tests and see if they are structured better, readabilty improved and if they cover testing the whole for-teacher page
This was referenced Jul 2, 2024
Closed
Merged
mergify bot pushed a commit that referenced this issue Jul 8, 2024
@Annelein
🧹 Cypress part4 (#5647)
061e446 
Fixes the following tests for #4027 :

- [x] home page
- [x] login page
- [x] recover page
- [x] signup page
- [x] subscribe page
@Annelein Annelein mentioned this issue Aug 1, 2024
Merged
mergify bot pushed a commit that referenced this issue Aug 9, 2024
@Annelein
🧪 Cypress part5 (#5683)
9c9ecad 
Fixes the following tests for #4027 :
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Annelein Annelein

Labels
cypress issues related to Cypress (front-end) testing
Projects
Hedy organization board
Status: In Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[TESTING] Cypress tests refactorization jpelay/hedy
3 participants
@Felienne @jpelay @Annelein