Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] foo.txt file appears in the repo - waiting for flask-commonmark to implement a fix #4540

Open
jtwaleson opened this issue Sep 24, 2023 · 3 comments
Assignees

Comments

@jtwaleson
Copy link
Collaborator

Describe the bug
A wild foo.txt file appeared in the root directory of the project. I removed it but it was re-added automatically due to a github workflow. After some investigation I found the source of the problem in the flask-commonmark package, and am waiting on getting an upstream fix in flask-commonmark merged. See https://gitlab.com/doug.shawhan/flask-commonmark/-/merge_requests/4

Note that this issue is NOT urgent at all. It just serves as documentation that this quirk exists for future contributors, and a reminder to update the package when a fix ever gets released.

@jtwaleson
Copy link
Collaborator Author

As the upstream library does not look to be actively maintained we can prevent this from happening by including it in the .gitignore file. This will ensure that the github actions that commit back to the repository do not include the file.

@jpelay
Copy link
Member

jpelay commented Oct 17, 2023

Ohhhh, thanks for figuring out where that file came from! It made me crazy and I had no idea!

As the upstream library does not look to be actively maintained we can prevent this from happening by including it in the .gitignore file. This will ensure that the github actions that commit back to the repository do not include the file.

Yes, last commit is from 2 years ago, I don't think they're merging your fix anytime soon.

May I ask how did you manage to find where the file came from?

@jtwaleson
Copy link
Collaborator Author

I use the silver searcher for finding stuff. I ran ag -ul foo.txt (the -u flag searches EVERYWHERE, also in the dependencies, -l shows the filenames).

mergify bot pushed a commit that referenced this issue Aug 15, 2024
Ignore the file `foo.txt` on Git. This file is automatically generated by the flask-commonmark package, and more info can be found in this issue #4540
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

2 participants