Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI idea] remove tabs when in programmer's mode #4719

Closed
Felienne opened this issue Nov 8, 2023 · 0 comments · Fixed by #4824
Closed

[UI idea] remove tabs when in programmer's mode #4719

Felienne opened this issue Nov 8, 2023 · 0 comments · Fixed by #4824
Assignees
@Annelein
Labels
good first issue Good for newcomers

Comments

@Felienne
Copy link
Member

Felienne commented Nov 8, 2023 •
edited
Loading

The adventure tabs don't really make sense in programmer's mode?

Idea
image

Steps to fix this would be to change the template to show the tabs only when we are not in programmer's mode.
@Felienne Felienne added the good first issue Good for newcomers label Nov 8, 2023
@Annelein Annelein mentioned this issue Nov 13, 2023
Closed
@Annelein Annelein mentioned this issue Nov 29, 2023
Merged
@mergify mergify bot closed this as completed in #4824 Dec 11, 2023
mergify bot pushed a commit that referenced this issue Dec 11, 2023
@Annelein
[UI] Developer mode toggle (#4824)
c23cb60 
Fixes #4719 . Developer's mode stays the same when reloading the page and adventures are not shown.

How to test: toggle the developers mode toggle and refresh the page.
<img width="1440" alt="Screenshot 2023-12-07 at 14 18 04" src="https://github.com/hedyorg/hedy/assets/48122190/37d61b06-df78-4fc3-922f-6c99a34eeb67">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Annelein Annelein

Labels
good first issue Good for newcomers
Projects
Hedy organization board
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[UI] Developer mode toggle hedyorg/hedy
[UI] Remove tabs in developer mode hedyorg/hedy
2 participants
@Felienne @Annelein