Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] InvalidSpaceWarning not being shown in the editor #4869

Closed
jpelay opened this issue Dec 7, 2023 · 3 comments · Fixed by #4880
Closed

[BUG] InvalidSpaceWarning not being shown in the editor #4869

jpelay opened this issue Dec 7, 2023 · 3 comments · Fixed by #4880

Comments

@jpelay
Copy link
Member

jpelay commented Dec 7, 2023

Describe the bug

The editor is not showing the warning for InvalidSpace and maybe for other warnings that come from the server?:

image
@Felienne
Copy link
Member

Felienne commented Dec 8, 2023

Hi @jpelay!

Yes, I was actually in the process of removing that whole exception (I have a draft PR on my laptop)

It is no longer needed because the editor strips leading spaces (So I think we can close this issue)

@jpelay
Copy link
Member Author

jpelay commented Dec 8, 2023

It is no longer needed because the editor strips leading spaces (So I think we can close this issue)

I don't think that's the case! See how the code that we send to the server actually has the leading spaces. Do you want me to work on this?
image

@Felienne
Copy link
Member

Felienne commented Dec 9, 2023

Weird! Then how can the code still run! I will dive in since I was working on a branch about it anyway.

@Felienne Felienne mentioned this issue Dec 9, 2023
Merged
@mergify mergify bot closed this as completed in #4880 Dec 12, 2023
mergify bot pushed a commit that referenced this issue Dec 12, 2023
@Felienne
[FIX] Add warning back in (#4880)
49dd7db 
Fixes #4869 

As far as I can see, @ToniSkulj removed this warning in #4320, I suspect by accident, but if not, let me know :) 

See:
<img width="1116" alt="image" src="https://github.com/hedyorg/hedy/assets/1003685/4c8d2319-6a9f-4772-8f3b-2541417bcff3">

**How to test**
Observe that code with a space at the start runs but also throws an error:

<img width="701" alt="image" src="https://github.com/hedyorg/hedy/assets/1003685/29e2191f-dbc8-4063-91ef-ebf24a1a896e">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Hedy organization board
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[FIX] Add warning back in hedyorg/hedy
2 participants
@Felienne @jpelay