Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI idea] Improvements for public adventures #4909

Closed
Felienne opened this issue Dec 15, 2023 · 0 comments · Fixed by #4938
Closed

[UI idea] Improvements for public adventures #4909

Felienne opened this issue Dec 15, 2023 · 0 comments · Fixed by #4938
Assignees

Comments

@Felienne
Copy link
Member

Felienne commented Dec 15, 2023

Now that the public adventures are live and I had a chance to play with them, I have a few requests for improvement. We can of course split this into separate issues where needed!

Update text above adventures

We recently added info text above the adventures, let's also explain public adventures there, with a link to the (yet to be written) teacher manual part about it.
image

Change teacher into author?

I am not really sure what the "teacher" column indicates, but I think it means author? An interesting question is if we want to keep the original author there or the author that cloned the adventure? I would lean towards (also?) showing the original author just so it is more clear what is what.

image

Show this is a dropdown

I first did not understand this was a dropdown (it misses the arrow down icon).
image

Of course that has to do with the lack of a general guideline for design of elements, but maybe this is a good moment to centralize the dropdown elements? In other places it does look like a dropdown, f.e. in customization:
image

Make tags multiselect

This I think maybe should not be a dropdown, because people might want to search for multiple tags (age and theme, for example)
image

Real preview for preview

Once @jtwaleson is ready with #4822, we can link to a preview in the Hedy UI rather than the edit UI, that would be a lot nicer I think!

Show a bit more info

A tile now only shows the title and some meta data, but there is some room in the tiles. Could we add maybe the first text line of the adventure, to give a better sense of what it is about?
image

@mergify mergify bot closed this as completed in #4938 Jan 9, 2024
mergify bot pushed a commit that referenced this issue Jan 9, 2024
Fixes #4909 
This PR improves the public adventures page, as described by felienne in the aforementioned issue. It also introduces some new things. Here's a list of things done:
- [x] Change "Teacher" column name to "Author" of an adventure.
   - Now we distinguish between the author and owner. E.g., if a you clone an adventure, you'd be the owner, but not the author. 
- [x] Dropdown indication
- [x] Tags multi-select dropdown
- [x] Preview mode for any (public) adventure 
   - clicking on the preview icon, takes the user to the code-level page where they can run their code for an adventure and explore what it encapsulates in different levels.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants