Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🧹 Refactor id's and data-cy's to underscore #5531

Closed
Annelein opened this issue May 14, 2024 · 0 comments · Fixed by #5584
Closed

🧹 Refactor id's and data-cy's to underscore #5531

Annelein opened this issue May 14, 2024 · 0 comments · Fixed by #5584
Assignees
@Annelein

Comments

@Annelein
Copy link
Collaborator

Annelein commented May 14, 2024 •
edited
Loading

for example:
<tbody id="class-user-table">
and
<td id="role_cell">

these id's and data-cy's should all contain underscore's

as discussed in the meeting: maybe also update the docs
@Annelein Annelein added the language Issues related to the Hedy language label May 14, 2024
@Annelein Annelein removed the language Issues related to the Hedy language label May 14, 2024
@Annelein Annelein self-assigned this May 14, 2024
@Annelein Annelein changed the title 🧹 Refactor id's and data-cy to underscore 🧹 Refactor id's and data-cy's to underscore May 14, 2024
@Annelein Annelein moved this to In Progress in Hedy organization board May 27, 2024
@Annelein Annelein mentioned this issue May 30, 2024
Merged
@mergify mergify bot closed this as completed in #5584 Jun 4, 2024
mergify bot pushed a commit that referenced this issue Jun 4, 2024
@Annelein
🧹 Refactor id's and data-cy's to underscore (#5584)
1bdb046 
Fixes #5531 

**How to test**
It is quite large so I will check Alpha regularly
- check if there are typos
- check a lot of buttons to see if they are still working
@Annelein Annelein moved this from In Progress to Ready for Review in Hedy organization board Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Annelein Annelein

Labels
None yet
Projects
Hedy organization board
Status: Ready for Review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🧹 Refactor id's and data-cy's to underscore hedyorg/hedy
1 participant
@Annelein