Only show language switcher on ace when admin #3327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Felienne
added
the
Keep-updated
Guess who just recorded a video that included an explanation of this feature 😭 |
mergify bot
pushed a commit
that referenced
this pull request
Sep 30, 2022
…3355) **Description** We partly re-implement the code deleted in #3327 where we decided to remove the language switcher from the code editor. We now re-introduce a "hide keyword switcher" but instead aim on the menubar dropdown keyword switcher. The back-end code can remain the same, we only had to make some adjustments to the front-end. **Fixes _issue or discussion number_** This PR fixes #3354. **How to test** Make sure you are in a class and have a keyword-supported-non-english profile language. Verify that you can see and use the keyword switcher dropdown from the menubar. When hidden using the class customizations the button should been gone.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the languages switcher on the ace editor for normal users. It has become a bit redundant, especially with the already existing keyword language switcher on the dropdown bar. We also remove the 'hide keyword switcher' option from the class customizations.
Fixes
This PR fixes #3322
How to test
Verify that the language switcher is still shown when being the admin, otherwise it should be hidden.