-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Language] Adding error to catch index out of bounds errors #3788
Conversation
Ah sorry I missed this in between all Cypress tests, sorry! Will take a look now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great improvement @jpelay!!
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
Description
Adds an exception to the code generated after transpiling to catch index out of bounds errors.
Things to do:
gettext
works inside hedy.py!)Fixes #3463
How to test
Since this is added after transpiling, should I add an e2e test?
Checklist
Done? Check if you have it all in place using this list:*
If you're unsure about any of these, don't hesitate to ask. We're here to help!