-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] order of slides' levels & pages for Turkish only #4552
Conversation
Thanks a lot for this @yilmazdurmaz, but we are working on a more generic solution, sorting all languages so the problem does not occur in the future, and we hope to finish that soon (See #4557) So I am closing this one. |
@Felienne Slides are one of the most important things for teachers before starting their classes and levels. Since I translated everything except high level quizzes, I want to start sharing Hedy with Turkish people. Though translated, this page ordering problem prevents me from doing that. It is like a drop of poison onto a finely cooked meal. Please assign a priority to re-ordering slide pages; unlike other yaml files, levels and pages are marked with numbers in slides. Or let me reopen this PR. |
Hi @yilmazdurmaz, we are currently working on a fix and we are really trying to get that out as soon as we can! You can follow the progress on #4557. I could potentially merge this fix, but only if weblate is not active (otherwise everything will be in conflict). Should that happen, I promise I will do my best to merge this in between other PRs, but just know we are working on it. It should really be fixed within a few days. |
@yilmazdurmaz, I have closed Weblate, let's see if this does not cause conflicts! |
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
Description
I manually reordered slide pages and levels for Turkish language. I first ordered page numbers in slides, then reordered levels. Also added a little touch to the last page of level 2. So from the file's perpective the things are alright.
Please check if editing the file this way is alright from the project's perspective and that of Weblate.
Fixes the ordering issue on #4480