Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] Commands optimizer #4563

Merged
merged 15 commits into from
Sep 27, 2023
Merged

[CHORE] Commands optimizer #4563

merged 15 commits into from
Sep 27, 2023

Conversation

Felienne
Copy link
Member

@Felienne Felienne commented Sep 27, 2023

A bit of performance detective work showed that the achievements code calls allCommands a lot, but allCommands actually parses the code, which is expensive.

A few more tweaks could be made:

  • Fix the TODO "hacks" I made to get this done
  • Optimize even further by parsing once, and passing the parse tree to allCommands instead of parsing twice
  • If we expand the hypothesis testing, remove the allcommands call there too (it now parses twice)

@ghost
Copy link

ghost commented Sep 27, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@rix0rrr rix0rrr marked this pull request as draft September 27, 2023 16:31
@rix0rrr rix0rrr marked this pull request as ready for review September 27, 2023 16:31
@mergify
Copy link
Contributor

mergify bot commented Sep 27, 2023

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 0bf9276 into main Sep 27, 2023
9 checks passed
@mergify mergify bot deleted the commands-optimizer branch September 27, 2023 17:32
@mergify
Copy link
Contributor

mergify bot commented Sep 27, 2023

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants