Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Creating Tags #4688

Merged
merged 21 commits into from
Nov 14, 2023
Merged

[UI] Creating Tags #4688

merged 21 commits into from
Nov 14, 2023

Conversation

hasan-sh
Copy link
Collaborator

@hasan-sh hasan-sh commented Oct 30, 2023

Stap one of the (content-management) improvement.

Fixes #4603
Depends-on #4722

Features

  • teachers can tag adventures in the customize-adventure view
  • tags are created once and never removed
  • so, tags can be added to and removed from adventures only

@ghost
Copy link

ghost commented Oct 31, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@Felienne Felienne changed the title [UI idea] Creating Tags [UI] Creating Tags Oct 31, 2023
@jpelay
Copy link
Member

jpelay commented Nov 10, 2023

Hi, Hasan! Is this PR still in progress? If so, can you mark it as a Draft? That way is easier for me and Felienne to know which PRs to take a look first.

@Felienne
Copy link
Member

Thanks @hasan-sh, I will try to take a look today!

@Felienne
Copy link
Member

Tagging works great @hasan-sh! I have one question though, if a teacher adds a tag, should we search the existing tags and suggest these? Otherwise I worry a bit we will soon have "grade 7" and "7th grade" etc. So I would prefer the add box to also be a search box suggesting similar tags:

image

If you are planning to do this in a separate PR, that is also totally fine by me! Then let's merge this and open an issue for the search within the tagging (which is different from search adventures by tag)

@Felienne
Copy link
Member

(also, note to self, we should not forget to add this table on test and prod!)

@Felienne
Copy link
Member

This should be good to go when I have merged Weblate!

Copy link
Contributor

mergify bot commented Nov 14, 2023

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit bc97947 into main Nov 14, 2023
11 checks passed
@mergify mergify bot deleted the adventure-tags branch November 14, 2023 08:38
@Felienne
Copy link
Member

Grrrrr that "depends-on" syntax of Mergify did not do the job :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI idea] Allow teachers to tag adventures
3 participants