[UI] Public adventures view #4757

hasan-sh · 2023-11-15T19:08:56Z

Fixes #4604

Info

Public adventures are listed as cards
Each card contains basic information about the adventure.
- creator, level, clones (# of times it's created), last update date, and tags
These are sorted by currenUser's adventures

Features and Todo

Teachers can navigate to their adventures by clicking on the title or edit button.
Teachers can clone or view adventures of others
- if they clone, a new copy of that adventure is created
- the user gets a notification that cloning succeeded
- the update is reflected by showing the newly cloned adventure only thus
- the other teacher's adventure that's cloned now, won't be visible.
Teachers can use 3 filters:
- Search
- Language
- Tags
- Country?
- User?
- Level?
add tests
allow filtering through url

- separate ts functions - more options; hide empty filters, links, info - more info to db; more data=power

ghost · 2023-11-15T19:10:46Z

👇 Click on the image for a new way to code review

Legend

for more information, see https://pre-commit.ci

…entures

Felienne · 2023-11-16T12:10:58Z

I love the tile UI @hasan-sh, looks very good!

Felienne · 2023-11-16T12:12:20Z

A few random thoughts:

Should we add "public" as a tickmark to the adventure overview:

(and maybe also show which ones are cloned?)

Felienne · 2023-11-16T12:32:42Z

If I click clone, the tile changes, which I found a bit confusing:

What does the bin mean, will it delete the adventure or the clone? The error message does not help me grasp the meaning

I think we can do without the bin button here? If people want to remove the adventure, they can do so from their adventure overview?

The same might be true for the add tags link, for which it is not clear if we are adding the tags to the original adventure or the close.

Also it is a bit confusing that it leads to the same edit view as the title link. Maybe we can make one link at the bottom with something like "edit directly"?

hasan-sh · 2023-11-16T12:56:45Z

A few random thoughts:

Should we add "public" as a tickmark to the adventure overview:
(and maybe also show which ones are cloned?)

Thought of that and put them in that table, but it got too crowded...

hasan-sh · 2023-11-16T12:58:42Z

A few random thoughts:
Should we add "public" as a tickmark to the adventure overview:

(and maybe also show which ones are cloned?)

Thought of that and put them in that table, but it got too crowded...

but the tables now have cloned_from and cloned_times (i.e. how many times is an adventure cloned!) for future ideas/usage.

Felienne · 2023-11-16T13:02:03Z

Thought of that and put them in that table, but it got too crowded...

Fair enough! We will think about a redesign of this page for the future and keep it in mind!

but the tables now have cloned_from and cloned_times (i.e. how many times is an adventure cloned!) for future ideas/usage.

Oooowwww, good thinking!! We could add cloned_times to the tile view so teachers can see popular adventures?

hasan-sh · 2023-11-16T13:05:17Z

If I click clone, the tile changes, which I found a bit confusing:
What does the bin mean, will it delete the adventure or the clone? The error message does not help me grasp the meaning
I think we can do without the bin button here? If people want to remove the adventure, they can do so from their adventure overview?

When a user clones an adventure, we create a brand new one for that user. I did this because we weren't sure whether cloned adventures should be syncronized. I think they shouldn't. So, the card changes because the adventure now belongs to the current user!

The same might be true for the add tags link, for which it is not clear if we are adding the tags to the original adventure or the close.
the main reason why i added this is to entice users to add tags since it's a new feature and great for data analysis later on!!

Also it is a bit confusing that it leads to the same edit view as the title link. Maybe we can make one link at the bottom with something like "edit directly"?

This was really temporary! I could add a button instead of the delete btn, but perhaps we want to change and add more things to this public adventures view; e.g., add adventures to classes for one or multiple levels.

hasan-sh · 2023-11-16T13:08:20Z

Fair enough! We will think about a redesign of this page for the future and keep it in mind!

INDEED! For instance, a card that has some info icon when clicked, it would show more info (in a modal) and/or direct to different places; same for classes!

hasan-sh · 2023-11-16T13:09:44Z

Oooowwww, good thinking!! We could add cloned_times to the tile view so teachers can see popular adventures?

Yess sure! Shall i add it as a filter? or just sort adventures by how many times they're cloned in the backend?

Felienne · 2023-11-16T13:34:47Z

Oooowwww, good thinking!! We could add cloned_times to the tile view so teachers can see popular adventures?

Yess sure! Shall i add it as a filter? or just sort adventures by how many times they're cloned in the backend?

Let's for now just put it as info on the tiles? We can do more if we have thought about it a bit more :)

Felienne · 2023-11-16T13:37:26Z

When a user clones an adventure, we create a brand new one for that user. I did this because we weren't sure whether cloned adventures should be syncronized. I think they shouldn't.

I agree!

So, the card changes because the adventure now belongs to the current user!

Ah I see. I understand the model now but I am not sure that makes sense for a user. Maybe we should have a modal that says: adventure cloned, do you want to go to edit? And then yes brings you to the edit page and no brings you back to search (closes the modal).

This was really temporary! I could add a button instead of the delete btn, but perhaps we want to change and add more things to this public adventures view; e.g., add adventures to classes for one or multiple levels.

Ok, never mind my comments about the bin then. Indeed, there could be a button with more options (later)

templates/public-adventures.html

templates/htmx-adventure-card.html

jpelay · 2023-11-16T15:28:28Z

website/database.py

@@ -585,6 +585,9 @@ def batch_get_adventures(self, adventure_ids):
        keys = {id: {"id": id} for id in adventure_ids}
        return ADVENTURES.batch_get(keys) if keys else {}

+    def get_public_adventures(self):


Let's not forget to add this table to prod and alpha when this gets deployed

This is the adventures table which exists on prod, right? Or does that have to be changed when we change its schema? Because I did include a new index to the table!

jpelay · 2023-11-16T15:31:04Z

Hi! Just left a few comments regarding the code :D I like the way this is looking so far. Great idea!

- two rows of same height

jpelay · 2023-12-04T14:23:53Z

Hello, @hasan-sh!

As we agreed upon during the meeting, for this PR to move forward, we first need to change the existing design of the Explore Programs' cards. Also we need a button here to flag submissions to the admin, for moderation purposes.

jpelay

We decided to merge this to main and use the styles for replacing the old styles!

jpelay · 2023-12-04T15:38:36Z

@hasan-sh Can you solve the conflicts 🙏 ?

mergify · 2023-12-04T15:38:49Z

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

jpelay · 2023-12-08T19:55:56Z

@hasan-sh Do you know why so many Cypress tests are failing in this PR? A bunch of stuff that doesn't even has to do with your changes, so maybe there was an error when merging?

Felienne · 2023-12-09T09:46:29Z

Yeah hopefully the new Cypress Cloud access will help us to figure out what is going on!

mergify · 2023-12-12T19:13:26Z

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

mergify · 2023-12-12T19:31:54Z

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

hasan-sh added 2 commits November 15, 2023 19:59

- independent adventure card

b934ca6

- separate ts functions - more options; hide empty filters, links, info - more info to db; more data=power

translation keys

5818d77

pre-commit-ci bot and others added 3 commits November 15, 2023 19:11

[pre-commit.ci] auto fixes from pre-commit.com hooks

41617d3

for more information, see https://pre-commit.ci

parameter type fix

f416de3

Merge branch 'pub-adventures' of github.com:hedyorg/hedy into pub-adv…

eec1845

…entures

jpelay reviewed Nov 16, 2023

View reviewed changes

Felienne changed the title ~~[UI idea] Public adventures view~~ [UI] Public adventures view Nov 17, 2023

hasan-sh added 6 commits November 20, 2023 13:05

only show tags if there

0922e0c

- notify when adventure is cloned

5bb9ba6

- two rows of same height

show how many times an adventure is cloned

77f71a0

translation keys

6bf1a77

Merge branch 'main' into pub-adventures

9aa726a

remove duplicate translation keys

d074624

hasan-sh requested a review from jpelay November 27, 2023 15:44

jpelay mentioned this pull request Dec 4, 2023

[UI idea] Switch public programs cards to new UI #4844

Closed

jpelay approved these changes Dec 4, 2023

View reviewed changes

hasan-sh and others added 5 commits December 5, 2023 15:32

Merge branch 'main' into pub-adventures

8d3fbaf

removed duplicate translation keys

11bf3bb

remove prints

3189528

Merge branch 'main' into pub-adventures

c7e169f

Merge branch 'main' into pub-adventures

889ba84

Felienne assigned hasan-sh Dec 11, 2023

Merge branch 'main' into pub-adventures

532aa43

Merge branch 'main' into pub-adventures

5956161

mergify bot merged commit c831922 into main Dec 12, 2023
11 checks passed

mergify bot deleted the pub-adventures branch December 12, 2023 19:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[UI] Public adventures view #4757

[UI] Public adventures view #4757

hasan-sh commented Nov 15, 2023 •

edited

Loading

ghost commented Nov 15, 2023 •

edited by ghost

Loading

Legend

Felienne commented Nov 16, 2023 •

edited

Loading

Felienne commented Nov 16, 2023

Felienne commented Nov 16, 2023

hasan-sh commented Nov 16, 2023

hasan-sh commented Nov 16, 2023

Felienne commented Nov 16, 2023

hasan-sh commented Nov 16, 2023 •

edited

Loading

hasan-sh commented Nov 16, 2023 •

edited

Loading

hasan-sh commented Nov 16, 2023

Felienne commented Nov 16, 2023

Felienne commented Nov 16, 2023

jpelay Nov 16, 2023

hasan-sh Nov 16, 2023

jpelay commented Nov 16, 2023

jpelay commented Dec 4, 2023

jpelay left a comment

jpelay commented Dec 4, 2023

mergify bot commented Dec 4, 2023

jpelay commented Dec 8, 2023

Felienne commented Dec 9, 2023

mergify bot commented Dec 12, 2023

mergify bot commented Dec 12, 2023

[UI] Public adventures view #4757

[UI] Public adventures view #4757

Conversation

hasan-sh commented Nov 15, 2023 • edited Loading

ghost commented Nov 15, 2023 • edited by ghost Loading

Legend

Felienne commented Nov 16, 2023 • edited Loading

Felienne commented Nov 16, 2023

Felienne commented Nov 16, 2023

hasan-sh commented Nov 16, 2023

hasan-sh commented Nov 16, 2023

Felienne commented Nov 16, 2023

hasan-sh commented Nov 16, 2023 • edited Loading

hasan-sh commented Nov 16, 2023 • edited Loading

hasan-sh commented Nov 16, 2023

Felienne commented Nov 16, 2023

Felienne commented Nov 16, 2023

jpelay Nov 16, 2023

Choose a reason for hiding this comment

hasan-sh Nov 16, 2023

Choose a reason for hiding this comment

jpelay commented Nov 16, 2023

jpelay commented Dec 4, 2023

jpelay left a comment

Choose a reason for hiding this comment

jpelay commented Dec 4, 2023

mergify bot commented Dec 4, 2023

jpelay commented Dec 8, 2023

Felienne commented Dec 9, 2023

mergify bot commented Dec 12, 2023

mergify bot commented Dec 12, 2023

hasan-sh commented Nov 15, 2023 •

edited

Loading

ghost commented Nov 15, 2023 •

edited by ghost

Loading

Felienne commented Nov 16, 2023 •

edited

Loading

hasan-sh commented Nov 16, 2023 •

edited

Loading

hasan-sh commented Nov 16, 2023 •

edited

Loading