Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CONTENT] Replacing the old teacher statistics section from all languages #4763

Merged
merged 6 commits into from
Nov 21, 2023

Conversation

Felienne
Copy link
Member

@Felienne Felienne commented Nov 16, 2023

Redo of #4733

Depends-On: #4735

@Felienne Felienne changed the title Removing the old teacher statistics section from all languages [CONTENT] Removing the old teacher statistics section from all languages Nov 16, 2023
@ghost
Copy link

ghost commented Nov 16, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@Felienne Felienne changed the title [CONTENT] Removing the old teacher statistics section from all languages [CONTENT] Replacing the old teacher statistics section from all languages Nov 16, 2023
@Felienne
Copy link
Member Author

Hi @jpelay!

As you can see, Marleen is adding this to the teacher manual, so maybe the optimization of this could be moved forward in time a bit? I worry teachers will start using it while it is not really... battle ready?

@jpelay
Copy link
Member

jpelay commented Nov 16, 2023

Hi @jpelay!

As you can see, Marleen is adding this to the teacher manual, so maybe the optimization of this could be moved forward in time a bit? I worry teachers will start using it while it is not really... battle ready?

Understood!!!

@Felienne
Copy link
Member Author

Hi @jpelay!
As you can see, Marleen is adding this to the teacher manual, so maybe the optimization of this could be moved forward in time a bit? I worry teachers will start using it while it is not really... battle ready?

Understood!!!

You're the best!! (We will wait a bit with deploying anyway because of CodeMirror I guess)

Copy link
Contributor

mergify bot commented Nov 21, 2023

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit c01b572 into main Nov 21, 2023
11 checks passed
@mergify mergify bot deleted the teacher-stats branch November 21, 2023 18:58
Copy link
Contributor

mergify bot commented Nov 21, 2023

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants