[FIX] Proper marking of flat compound statements while debugging #4766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpelay
changed the title
Felienne
approved these changes
Dec 1, 2023
|
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
jpelay
commented
Dec 4, 2023
| @@ -452,7 +451,7 @@ describe('Test editor box functionality', () => { | |||
| cy.focused().type("repeat 1 times if x is x print 'a'\nelse print 'b'"); | |||
|
|
|||
| cy.get('#debug_button').click(); | |||
| cy.wait('@parse'); | |||
| cy.wait('@parse') | |||
There was a problem hiding this comment.
I removed a semicolon and they magically worked again 😐
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes the regex that was used to group the different parts of the flat compound statements to be able to properly color nested flat statements. Also changes the way the line is computed.
A nested flat statement are
ifwithrepeatinside or viceversa. You cannot place anifinside aif, but you can place arepeatinside arepeat.Even though we say these statements are flat, it's possible to add newlines between them. And this is where the problem lied. When these statements where split between lines, the code did not account for beginning and end of statements properly.
**Fixes #4725 **
How to test
I added a couple of tests!