Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] allow adventures to be added to multiple levels #4793

Merged
merged 38 commits into from
Dec 18, 2023
Merged

Conversation

hasan-sh
Copy link
Collaborator

@hasan-sh hasan-sh commented Nov 23, 2023

Idea
In this PR, I'm converting how adventures relate to levels. Currently, an adventure can be added to one level only. The goal is to allow using adventures in different levels.

Fixes #3573

Questions and Concerns:

  • What happens if an adventure contains code that's not allowed (or is used differently) in different levels?
    • Perhaps we could allow adding to levels that have the same restrictions?
    • Or just inform the teachers of this limitation.

How to test?

  • npm install
  • add adventure to levels in the customize-adventure view

@ghost
Copy link

ghost commented Nov 23, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@hasan-sh hasan-sh marked this pull request as ready for review December 13, 2023 12:34
@hasan-sh
Copy link
Collaborator Author

Please don't mind the amount of commits! Most of which were a part of testing cypress, so see files changed for review!

@Felienne
Copy link
Member

Hi @hasan-sh!

What is the status of this? I am trying to clean up the open PRs a bit.

@hasan-sh
Copy link
Collaborator Author

Hi @hasan-sh!

What is the status of this? I am trying to clean up the open PRs a bit.

It's ready for review!

@Felienne
Copy link
Member

Hi @hasan-sh!
What is the status of this? I am trying to clean up the open PRs a bit.

It's ready for review!

Thanks! Can you address the conflicts?

Copy link
Member

@Felienne Felienne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great @hasan-sh!!

@Felienne
Copy link
Member

What happens if an adventure contains code that's not allowed (or is used differently) in different levels?

  • Perhaps we could allow adding to levels that have the same restrictions?
  • Or just inform the teachers of this limitation.

Good question! I don't think we need to do something here in code though. If a teacher accidentally adds a "wrong" adventure, students will let them know soon enough!

Copy link
Contributor

mergify bot commented Dec 18, 2023

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

Copy link
Contributor

mergify bot commented Dec 18, 2023

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 2ab02d3 into main Dec 18, 2023
11 checks passed
@mergify mergify bot deleted the adventure-all-levels branch December 18, 2023 16:59
Copy link
Contributor

mergify bot commented Dec 18, 2023

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

[UI idea] Adding an adventure to more levels at once
2 participants