Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] tags dropdown items get their content width only #4818

Merged
merged 3 commits into from
Nov 30, 2023
Merged

[BUG] tags dropdown items get their content width only #4818

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ffe67a8
fix width and set autocomplete to off
hasan-sh Nov 28, 2023
dc12b94
Merge branch 'main' into fix-tags-items-width
jpelay Nov 30, 2023
2f0a91b
Merge branch 'main' into fix-tags-items-width
mergify[bot] Nov 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion templates/customize-adventure.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ <h3 class="text-center mt-0 mb-4">{{_('general_settings')}}</h3>
<div class="flex flex-row items-center mb-4">
<label for="tags" class="inline-block w-40 text-xl">{{_('tags')}}</label>
<div class="flex flex-row w-full relative" id="add_tags">
<input type="text" name="tag" placeholder="{{_('tag_input_placeholder')}}" id="search_tags_input"
<input type="text" name="tag" autocomplete="off" placeholder="{{_('tag_input_placeholder')}}" id="search_tags_input"
class="appearance-none w-full bg-gray-200 border border-gray-200 text-gray-700 py-3 px-4 ltr:pr-8 rtl:pl-8 rounded"
hx-trigger="enter"
hx-post="/tags/create/{{adventure.id}}" hx-target="#tags-list" hx-swap="outerHTML"
Expand Down
2 changes: 1 addition & 1 deletion templates/htmx-tags-dropdown-item.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<!-- Requires #search_tags_input to exist -->
<div class="relative cursor-pointer !w-full border-2 rounded-lg border-green-300 p-2 px-5 m-1 shadow"
<div class="relative cursor-pointer border-2 rounded-lg border-green-300 p-2 px-5 m-1 shadow"
id="tag_{{tag['name']}}" hx-post="/tags/create/{{adventure_id}}/{{tag.name}}" hx-target="#tags-list"
hx-swap="outerHTML" _="on click event.stopPropagation()
on htmx:afterRequest
Expand Down
Loading