Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Allow users to navigate between exercises using header #4819

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

hasan-sh
Copy link
Collaborator

@hasan-sh hasan-sh commented Nov 28, 2023

Fixes #4441

Enhanced the overall ui of exercises.

  • Better header;
    • Clear background and font weight on the currently selected exercise
    • Also, users now can click to navigate through existing exercises
  • Next button doesn't show currenlty.
    • Hiding it always is fine, since navigation is possible using the headers.

How to test

- overal UI enhancements
@ghost
Copy link

ghost commented Nov 28, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@Felienne
Copy link
Member

Nice, the switching now works:

image

I am wondering though, how will kids know there is a second puzzle? The UI now does not really invite to click the 2 I am afraid. Maybe we should make the "advance" button that now goes to the quiz, go to the next puzzle?

We once had an issue coining the idea to make the quiz and Parsons more similar (#4001) but it was closed without us pursuing it further. I think we should do something like that still, make the parsons look more like the quiz with a clear advance step (we can still merge this, of course!)

@Felienne
Copy link
Member

(added the original one to the project board for the meeting, but if I am needed to discuss, feel free to skip it till next time)

Copy link
Contributor

mergify bot commented Nov 28, 2023

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit eba9aac into main Nov 28, 2023
11 checks passed
@mergify mergify bot deleted the enhance-parsons branch November 28, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Parsons puzzle: second exercise is unreachable
2 participants