-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UI, FIX] Fixes placing of checkbox and eye icon on grid #4834
Conversation
{% if not loop.last %}border-r{% endif %} | ||
{% if not is_last_student %}border-b{% endif %}" | ||
> | ||
<div class="grid grid grid-cols-[repeat(3,_minmax(25px,_1fr))] gap-3"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used this weird class because I needed the grid to be at least 25px of width. Do you guys think it's better like this or maybe creating a class on styles.css?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
Description
Changes the table elements to be each a table layout of 3 columns, where the first column is empty, for alignment, the second one is the checkbox and the third one is the eye. This fixes the overflowing behavior that the elements of this table presented.
Worth noting that this page will be moved from here to the dashboard, but we need this fix shipped because it's very annoying!
Fixes this comment on #4580
How to test