Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI, FIX] Fixes placing of checkbox and eye icon on grid #4834

Merged
merged 2 commits into from
Dec 2, 2023

Conversation

jpelay
Copy link
Member

@jpelay jpelay commented Nov 30, 2023

Description

Changes the table elements to be each a table layout of 3 columns, where the first column is empty, for alignment, the second one is the checkbox and the third one is the eye. This fixes the overflowing behavior that the elements of this table presented.

Worth noting that this page will be moved from here to the dashboard, but we need this fix shipped because it's very annoying!

Fixes this comment on #4580

How to test

  • Make sure that some students have adventures done for a particular class.
  • Go to the class and click on Overview of programs per adventure.
  • Zoom-in and out and see that the elements do not overflow or mess with each other

{% if not loop.last %}border-r{% endif %}
{% if not is_last_student %}border-b{% endif %}"
>
<div class="grid grid grid-cols-[repeat(3,_minmax(25px,_1fr))] gap-3">
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used this weird class because I needed the grid to be at least 25px of width. Do you guys think it's better like this or maybe creating a class on styles.css?

@jpelay jpelay requested a review from hasan-sh December 1, 2023 20:46
@Felienne
Copy link
Member

Felienne commented Dec 2, 2023

I wanted to review this, but I don't think I know how to get the issue in view? For me it looks fine in main?

image

@jpelay
Copy link
Member Author

jpelay commented Dec 2, 2023

I wanted to review this, but I don't think I know how to get the issue in view? For me it looks fine in main?

image

Try submitting the print adventure from one of the students ! And then reduce the size of the page by doing zoom of resizing the window, then it shouldn't appear!

Copy link
Member

@Felienne Felienne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, got it now!

image

This PRi indeed fixes the issue.

Copy link
Contributor

mergify bot commented Dec 2, 2023

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 100cf8e into hedyorg:main Dec 2, 2023
9 checks passed
Copy link
Contributor

mergify bot commented Dec 2, 2023

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI idea] Improve grid layout and stats performance
2 participants