Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 correctly translate empty string #4949

Merged
merged 2 commits into from
Jan 3, 2024
Merged

🐞 correctly translate empty string #4949

merged 2 commits into from
Jan 3, 2024

Conversation

Felienne
Copy link
Member

@Felienne Felienne commented Jan 3, 2024

Fixes #4943

@Felienne Felienne requested a review from hasan-sh January 3, 2024 14:15
@ghost
Copy link

ghost commented Jan 3, 2024

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

Copy link
Collaborator

@hasan-sh hasan-sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

Copy link
Contributor

mergify bot commented Jan 3, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit d6a33a4 into main Jan 3, 2024
11 checks passed
@mergify mergify bot deleted the translate-empty branch January 3, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] changing keyword language not working
2 participants