Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎶 Add support for chords #4981

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

🎶 Add support for chords #4981

wants to merge 4 commits into from

Conversation

Felienne
Copy link
Member

@Felienne Felienne commented Jan 10, 2024 •
edited
Loading

Fixes #4964

How to test

Follow these steps to verify this PR works as intended:

  • Try play C4 D4 E4 from level 3
  • I also added a few tests

Checklist
Done? Check if you have it all in place using this list: (mark with x if done)

  • Contains one of the PR categories in the name
  • Describes changes in the format above
  • Links to an existing issue or discussion
  • Has a "How to test" section

@ghost
Copy link

ghost commented Jan 10, 2024 •
edited by ghost
Loading

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@jpelay jpelay added the music label Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
keep-open music
Projects
Hedy organization board
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🎶 Support chords
2 participants
@Felienne @jpelay