Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Translation of strings starter #5031

Draft
wants to merge 29 commits into
base: main
Choose a base branch
from
Draft

[WIP] Translation of strings starter #5031

wants to merge 29 commits into from

Conversation

Felienne
Copy link
Member

@Felienne Felienne commented Jan 25, 2024

Work in progress for the simplest first step in #4656, translating a plain text string from one language to the other. I will make a list of steps here that I have taken, and a list of things that remain to be done.

How does current, keyword translation work?
Translation now work by analyzing the parse tree, adding nodes that need translation (currently only keywords) and then replaces these keywords with simple string replacement. If you need more details, @boryanagoncharenko (who is also in Discord) created this and can help you out.

Steps taken in this PR

@ghost
Copy link

ghost commented Jan 25, 2024

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@Felienne
Copy link
Member Author

Hi @rania74!

I have made a small starter for that that translates code! I will add some more details but you can start exploring this PR.

@Felienne
Copy link
Member Author

This PR is a starter for @rania74, so it should stay open!

@Felienne
Copy link
Member Author

Felienne commented May 8, 2024

Hi people reading along (most likely @rania74)

I have made this PR a bit more extensive, now calling Google translate, and translating content inside of ASK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

1 participant