Allowing unsetting of favourite program

[TiBiBa]

Fixes #5132

How to test:

1. Login (have a public profile and a public program)
2. Click on favourite a program and unfavourite the program

Screen.Recording.2024-03-27.at.10.21.31.mov

[ghost]

👇 Click on the image for a new way to code review

Legend

[Felienne]

Hi @hasan-sh!

This is a somewhat longstanding R, could you pick it up? I am not sure how ready it is but I think it can be a small PR in between other things.

[hasan-sh]

Hi @hasan-sh!

This is a somewhat longstanding R, could you pick it up? I am not sure how ready it is but I think it can be a small PR in between other things.

Will do so after the autosave PR and finish investigating the login problems that we discussed with the teachers!

[hasan-sh]

I cannot favourite a program without a refresh. I'll review the code once this is done! Let me know if you need any help:)

[Annelein]

@hasan-sh I've also added a test for favouriting and unfavouriting a program as mentioned in #4251, can you let me know if this is how a test is supposed to be?

[hasan-sh]

Great @Annelein , will review your PR

[Annelein]

Great @Annelein , will review your PR

Thank you! Then I can continue working on #4251 if I know that this is the correct test approach

[hasan-sh]

Hi, i remember making it possible to update the UI from TS; ffa813a#diff-810bc5b30fefd1c7d50d825f1331efb7cda58a958fdbe93d015904aed1735a47R29-R35

Why did you move the data-starred attribute to the i element instead of the container? Now you the ui isn't updating as it was!

I suggested a change that fixes the issue, but do take a look at the test and whether anything else depends on what i changed!

[Annelein]

Hi, i remember making it possible to update the UI from TS; ffa813a#diff-810bc5b30fefd1c7d50d825f1331efb7cda58a958fdbe93d015904aed1735a47R29-R35

Why did you move the data-starred attribute to the i element instead of the container? Now you the ui isn't updating as it was!

I did this because the test was failing because it would miss click because this is the space the container takes up, so now the test fails again:

Pushed another fix.

[hasan-sh]

@Annelein the set_favourite_program uses need to be fixed. Try to make a program private after favouriting it.

[mergify]

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

[mergify]

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).