-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
💻 Create adventure within class #5154
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, but i think the idea is that when you click on this button, the teacher would expect that adventure to be added to the current class. So, if this adventure is for level 1 and 4, it'd be added to the customization class for these levels, otherwise the teacher would still have to go to their class, customization page, and add the adventure for the required levels!
I think I missed that in the meeting but I will add it! |
…g/hedy into create-adventure-in-class
This needs to wait for #5026 to be merged |
for more information, see https://pre-commit.ci
…g/hedy into create-adventure-in-class
for more information, see https://pre-commit.ci
…g/hedy into create-adventure-in-class
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Co-authored-by: Hasan_sh <[email protected]>
…g/hedy into create-adventure-in-class
for more information, see https://pre-commit.ci
…g/hedy into create-adventure-in-class
@hasan-sh thanks for the thorough testing! helps a lot, solved all of your comments now hopefully |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With these, i think we should be good to goooo:)
@hasan-sh check! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's gooo!
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
Fixes #4633 and fixes #5182
Create an adventure inside a class, which is automatically added to the class(es) and level(s) selected.
Screen.Recording.2024-03-01.at.18.53.15.mov