Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💻 Create adventure within class #5154

Merged
merged 82 commits into from
Mar 20, 2024
Merged

💻 Create adventure within class #5154

merged 82 commits into from
Mar 20, 2024

Conversation

Annelein
Copy link
Collaborator

@Annelein Annelein commented Feb 15, 2024

Fixes #4633 and fixes #5182
Create an adventure inside a class, which is automatically added to the class(es) and level(s) selected.

Screen.Recording.2024-03-01.at.18.53.15.mov

@Annelein Annelein self-assigned this Feb 15, 2024
@ghost
Copy link

ghost commented Feb 15, 2024

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

Copy link
Collaborator

@hasan-sh hasan-sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, but i think the idea is that when you click on this button, the teacher would expect that adventure to be added to the current class. So, if this adventure is for level 1 and 4, it'd be added to the customization class for these levels, otherwise the teacher would still have to go to their class, customization page, and add the adventure for the required levels!

@Annelein
Copy link
Collaborator Author

This is great, but i think the idea is that when you click on this button, the teacher would expect that adventure to be added to the current class. So, if this adventure is for level 1 and 4, it'd be added to the customization class for these levels, otherwise the teacher would still have to go to their class, customization page, and add the adventure for the required levels!

I think I missed that in the meeting but I will add it!

@Annelein
Copy link
Collaborator Author

I think I missed that in the meeting but I will add it!

This needs to wait for #5026 to be merged

@Felienne
Copy link
Member

@hasan-sh #5026 is in, so this can be merged, I think? Can you approve?

@Annelein
Copy link
Collaborator Author

@hasan-sh #5026 is in, so this can be merged, I think? Can you approve?

I need to add something to it now that #5026 is merged! Will do it now

@Annelein
Copy link
Collaborator Author

@hasan-sh thanks for the thorough testing! helps a lot, solved all of your comments now hopefully

@hasan-sh hasan-sh self-requested a review March 19, 2024 12:33
Copy link
Collaborator

@hasan-sh hasan-sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With these, i think we should be good to goooo:)

website/for_teachers.py Outdated Show resolved Hide resolved
website/for_teachers.py Outdated Show resolved Hide resolved
@Annelein
Copy link
Collaborator Author

@hasan-sh check!

@Annelein Annelein requested a review from hasan-sh March 20, 2024 14:51
Copy link
Collaborator

@hasan-sh hasan-sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's gooo!

Copy link
Contributor

mergify bot commented Mar 20, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 591d66d into main Mar 20, 2024
12 checks passed
@mergify mergify bot deleted the create-adventure-in-class branch March 20, 2024 16:02
Copy link
Contributor

mergify bot commented Mar 20, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

💻 Add adventure to class [UI idea] Create adventure from class page
3 participants