Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💻 Front page start learning/teaching #5200

Merged
merged 56 commits into from
Mar 9, 2024
Merged

💻 Front page start learning/teaching #5200

merged 56 commits into from
Mar 9, 2024

Conversation

Annelein
Copy link
Collaborator

@Annelein Annelein commented Mar 1, 2024

Fixes #4655
Depends-On: #5156

Screenshot 2024-03-01 at 11 31 37

Start teaching goes to:

  • if not logged in: signup?teacher=true
  • if logged in as teacher: for-teachers
  • if logged in as student: my-profile

In the future, we want it to be linked to #5183

@Annelein Annelein changed the title 💻 Front page 💻 Front page start learning/teaching Mar 1, 2024
@Annelein Annelein requested review from jpelay and hasan-sh March 1, 2024 11:23
@Annelein
Copy link
Collaborator Author

Annelein commented Mar 5, 2024

@hasan-sh you can review this?

@Felienne
Copy link
Member

Felienne commented Mar 6, 2024

Hi @Annelein!

How you are seeing some snow there!

Can you fix the conflicts and the tests?

image

Thanks!

@Felienne
Copy link
Member

Felienne commented Mar 6, 2024

(it looks great, so if @hasan-sh is ok with the code, we can merge and deploy this!)

@Annelein
Copy link
Collaborator Author

Annelein commented Mar 6, 2024

Hi @Annelein!

How you are seeing some snow there!

Can you fix the conflicts and the tests?

image

Thanks!

Snow is great!! All my open PR's are depending on #5156 , those translations are made in that PR.... So waiting for it to be merged, I asked @hasan-sh many times or for a workaround

@hasan-sh
Copy link
Collaborator

hasan-sh commented Mar 6, 2024

Hi @Annelein!
How you are seeing some snow there!
Can you fix the conflicts and the tests?
image
Thanks!

Snow is great!! All my open PR's are depending on #5156 , those translations are made in that PR.... So waiting for it to be merged, I asked @hasan-sh many times or for a workaround

I think @jpelay is going to review that PR asap, so should be solved. But you could always just copy the translation keys from that pr!!

Copy link
Collaborator

@hasan-sh hasan-sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

nifouprog and others added 16 commits March 8, 2024 07:34
Currently translated at 81.5% (553 of 678 strings)

Co-authored-by: Nifou <[email protected]>
Translate-URL: https://hosted.weblate.org/projects/hedy/adventures/fr/
Translation: Hedy/Adventures
Currently translated at 35.2% (240 of 680 strings)

Translation: Hedy/Adventures
Translate-URL: https://hosted.weblate.org/projects/hedy/adventures/bg/
Currently translated at 56.4% (384 of 680 strings)

Translation: Hedy/Adventures
Translate-URL: https://hosted.weblate.org/projects/hedy/adventures/de/
Currently translated at 37.3% (254 of 680 strings)

Translation: Hedy/Adventures
Translate-URL: https://hosted.weblate.org/projects/hedy/adventures/el/
Currently translated at 92.2% (627 of 680 strings)

Translation: Hedy/Adventures
Translate-URL: https://hosted.weblate.org/projects/hedy/adventures/es/
Currently translated at 38.8% (264 of 680 strings)

Translation: Hedy/Adventures
Translate-URL: https://hosted.weblate.org/projects/hedy/adventures/hu/
Currently translated at 50.1% (341 of 680 strings)

Translation: Hedy/Adventures
Translate-URL: https://hosted.weblate.org/projects/hedy/adventures/id/
Currently translated at 86.6% (589 of 680 strings)

Translation: Hedy/Adventures
Translate-URL: https://hosted.weblate.org/projects/hedy/adventures/nl/
Currently translated at 31.1% (212 of 680 strings)

Translation: Hedy/Adventures
Translate-URL: https://hosted.weblate.org/projects/hedy/adventures/pt_PT/
Currently translated at 69.8% (475 of 680 strings)

Translation: Hedy/Adventures
Translate-URL: https://hosted.weblate.org/projects/hedy/adventures/pt_BR/
Currently translated at 36.7% (250 of 680 strings)

Translation: Hedy/Adventures
Translate-URL: https://hosted.weblate.org/projects/hedy/adventures/bn/
Currently translated at 38.9% (265 of 680 strings)

Translation: Hedy/Adventures
Translate-URL: https://hosted.weblate.org/projects/hedy/adventures/cs/
Currently translated at 37.0% (252 of 680 strings)

Translation: Hedy/Adventures
Translate-URL: https://hosted.weblate.org/projects/hedy/adventures/hi/
Currently translated at 36.4% (248 of 680 strings)

Translation: Hedy/Adventures
Translate-URL: https://hosted.weblate.org/projects/hedy/adventures/sw/
Currently translated at 47.3% (322 of 680 strings)

Translation: Hedy/Adventures
Translate-URL: https://hosted.weblate.org/projects/hedy/adventures/it/
Currently translated at 41.3% (281 of 680 strings)

Translation: Hedy/Adventures
Translate-URL: https://hosted.weblate.org/projects/hedy/adventures/ar/
weblate and others added 27 commits March 8, 2024 08:01
Currently translated at 32.7% (223 of 680 strings)

Translation: Hedy/Adventures
Translate-URL: https://hosted.weblate.org/projects/hedy/adventures/he/
Currently translated at 74.4% (506 of 680 strings)

Translation: Hedy/Adventures
Translate-URL: https://hosted.weblate.org/projects/hedy/adventures/sv/
Currently translated at 29.1% (198 of 680 strings)

Translation: Hedy/Adventures
Translate-URL: https://hosted.weblate.org/projects/hedy/adventures/ko/
Currently translated at 37.7% (257 of 680 strings)

Translation: Hedy/Adventures
Translate-URL: https://hosted.weblate.org/projects/hedy/adventures/tn/
Currently translated at 33.0% (225 of 680 strings)

Translation: Hedy/Adventures
Translate-URL: https://hosted.weblate.org/projects/hedy/adventures/ur/
Currently translated at 32.9% (224 of 680 strings)

Translation: Hedy/Adventures
Translate-URL: https://hosted.weblate.org/projects/hedy/adventures/th/
Currently translated at 43.8% (298 of 680 strings)

Translation: Hedy/Adventures
Translate-URL: https://hosted.weblate.org/projects/hedy/adventures/sq/
Currently translated at 35.4% (241 of 680 strings)

Translation: Hedy/Adventures
Translate-URL: https://hosted.weblate.org/projects/hedy/adventures/uk/
Currently translated at 32.5% (221 of 680 strings)

Translation: Hedy/Adventures
Translate-URL: https://hosted.weblate.org/projects/hedy/adventures/pa_PK/
Currently translated at 33.2% (226 of 680 strings)

Translation: Hedy/Adventures
Translate-URL: https://hosted.weblate.org/projects/hedy/adventures/vi/
Currently translated at 33.0% (225 of 680 strings)

Translation: Hedy/Adventures
Translate-URL: https://hosted.weblate.org/projects/hedy/adventures/tl/
Currently translated at 34.8% (237 of 680 strings)

Translation: Hedy/Adventures
Translate-URL: https://hosted.weblate.org/projects/hedy/adventures/fi/
Currently translated at 33.3% (227 of 680 strings)

Translation: Hedy/Adventures
Translate-URL: https://hosted.weblate.org/projects/hedy/adventures/te/
Currently translated at 33.5% (228 of 680 strings)

Translation: Hedy/Adventures
Translate-URL: https://hosted.weblate.org/projects/hedy/adventures/zh_Hant/
Currently translated at 42.3% (288 of 680 strings)

Translation: Hedy/Adventures
Translate-URL: https://hosted.weblate.org/projects/hedy/adventures/ca/
Currently translated at 32.9% (224 of 680 strings)

Translation: Hedy/Adventures
Translate-URL: https://hosted.weblate.org/projects/hedy/adventures/ro/
Currently translated at 35.8% (244 of 680 strings)

Translation: Hedy/Adventures
Translate-URL: https://hosted.weblate.org/projects/hedy/adventures/da/
Currently translated at 31.6% (215 of 680 strings)

Translation: Hedy/Adventures
Translate-URL: https://hosted.weblate.org/projects/hedy/adventures/sr/
Currently translated at 8.6% (59 of 680 strings)

Translation: Hedy/Adventures
Translate-URL: https://hosted.weblate.org/projects/hedy/adventures/pap/
Copy link
Contributor

mergify bot commented Mar 9, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit b8898c7 into main Mar 9, 2024
11 checks passed
@mergify mergify bot deleted the front-page branch March 9, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI idea] Replace "try it" button on the front-page
5 participants