Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💻 pair with other teachers #5213

Merged
merged 6 commits into from
Mar 8, 2024
Merged

💻 pair with other teachers #5213

merged 6 commits into from
Mar 8, 2024

Conversation

hasan-sh
Copy link
Collaborator

@hasan-sh hasan-sh commented Mar 6, 2024

Fixes #5212

How to test?

  • sign up as a new teacher
  • don't forget to check the checkbox that has the label: "I would like to be paired with another teacher for help"!

@Felienne
Copy link
Member

Felienne commented Mar 8, 2024

Hi @hasan-sh! Is there a reason this is still a draft?

@hasan-sh
Copy link
Collaborator Author

hasan-sh commented Mar 8, 2024

Hi @hasan-sh! Is there a reason this is still a draft?

Hey, just had to add the translation keys! If you review it and agree, it could be merged:)

@Felienne Felienne marked this pull request as ready for review March 8, 2024 17:36
@Felienne
Copy link
Member

Felienne commented Mar 8, 2024

hmmmm I fixed the keys, but now we have a Cypress test failing for the public page? Not sure what is the issue there.

Copy link
Contributor

mergify bot commented Mar 8, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 0a1bbe5 into main Mar 8, 2024
11 checks passed
@mergify mergify bot deleted the pair-with-teacher branch March 8, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💻 Add tickmark "I would like to be paired with another teacher for help"
2 participants