Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💻 teachers feedback option #5215

Merged
merged 19 commits into from
Mar 13, 2024
Merged

💻 teachers feedback option #5215

merged 19 commits into from
Mar 13, 2024

Conversation

hasan-sh
Copy link
Collaborator

@hasan-sh hasan-sh commented Mar 6, 2024

Fixes #5205

How to test?

  • go to any page,
  • you should see the feedback button in the bottom-right corner.
  • Click it, write a message and select category.
  • send it

@hasan-sh hasan-sh marked this pull request as ready for review March 12, 2024 14:09
@Felienne
Copy link
Member

Can you review this @Annelein?

Copy link
Collaborator

@Annelein Annelein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like it would look just a bit cleaner if the rounded white background would cover the whole size of the feedback icon?

Screenshot 2024-03-12 at 16 38 13

Besides that it looks good!! Very nice feature

@hasan-sh
Copy link
Collaborator Author

hasan-sh commented Mar 13, 2024

I feel like it would look just a bit cleaner if the rounded white background would cover the whole size of the feedback icon?

Hey, i agree, just adjusted it!

image

Copy link
Contributor

mergify bot commented Mar 13, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit b7c6535 into main Mar 13, 2024
12 checks passed
@mergify mergify bot deleted the feedback branch March 13, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💻 Allow teachers to give feedback on any page
3 participants