Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪲 Escape internal var used in repeat #5256

Merged
merged 2 commits into from
Mar 15, 2024
Merged

Conversation

boryanagoncharenko
Copy link
Collaborator

@boryanagoncharenko boryanagoncharenko commented Mar 13, 2024

Fixes #5255
The internal variable i used in repeat statements is now escaped with the __ prefix, so that it does not show in the output window.

How to test

  • Run Hedy locally and run the following snippets for the specified levels. Ensure that the i variable does not appear in the blue variables list in the upper right corner of the output window:

Level 7:

options is 1, 2, 3, 4, 5
repeat 5 times print options at random

Level 8:

options is 1, 2, 3, 4, 5
repeat 5 times
  print options at random

Copy link
Member

@jpelay jpelay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works!
image

Copy link
Contributor

mergify bot commented Mar 15, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 5e5ee55 into main Mar 15, 2024
12 checks passed
@mergify mergify bot deleted the repeat_refactoring_5255 branch March 15, 2024 17:41
Copy link
Contributor

mergify bot commented Mar 15, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🪲 Internal variable in repeat i should be escaped
2 participants