🚚 Don't rewrite emoji in YAML files #5273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current autoformatting script is replacing emoji with their Unicode escape counterpart. Update the version of Ruamel YAML to a version which doesn't have this behavior anymore, and keeps the emoji in the file. Move the running of the YAML autoformatter out of the pre-commit job and into the doit script `_autopr` which runs in a separate GitHub Actions job.
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current autoformatting script is replacing emoji with their Unicode escape counterpart. Update the version of Ruamel YAML to a version which doesn't have this behavior anymore, and keeps the emoji in the file.
Move the running of the YAML autoformatter out of the pre-commit job and into the doit script
_autoprwhich runs in a separate GitHub Actions job.