Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🖊️ Add new indent error messages for level 8 #5283

Merged
merged 3 commits into from
Mar 22, 2024
Merged

Conversation

boryanagoncharenko
Copy link
Collaborator

@boryanagoncharenko boryanagoncharenko commented Mar 20, 2024

Fixes #3270
Level 8 introduces indentation and allows single blocks while later levels allow nested blocks. Therefore, level 8 requires slightly different error messages.

Please consider whether the error messages could have better text.

How to test
Run Hedy locally and run the following snippets in level 8. The error messages should be meaningful and should not mention 'block in a block':

print 'test'
    print 'Hello folks'
repeat 5 times
print 'Hello folks'
repeat 5 times
    print 'test'
        print 'Hello folks'
repeat 5 times
    print 'test'
      print 'Hello folks'
repeat 5 times
    print 'test'
  print 'Hello folks'

@jpelay jpelay self-assigned this Mar 21, 2024
Copy link
Member

@jpelay jpelay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything works!!!

Copy link
Contributor

mergify bot commented Mar 21, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

Copy link
Contributor

mergify bot commented Mar 22, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 675af90 into main Mar 22, 2024
12 checks passed
@mergify mergify bot deleted the indent_errors_3270 branch March 22, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[BUG] block in block error message should not show without repeat/if
2 participants