Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪲 prevent preview adventure from overflowing in the top of the screen #5307

Merged
merged 3 commits into from
Apr 1, 2024

Conversation

Annelein
Copy link
Collaborator

@Annelein Annelein commented Mar 25, 2024

Fixes #5152
Fixes #5261

How to test

  1. Edit an adventure and add a lot of text/code
  2. Click on preview adventure
  3. The adventure is now shown in the middle of the screen and if it is big it becomes scrollable
Screen.Recording.2024-03-25.at.14.03.26.mov

Copy link
Member

@Felienne Felienne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah thanks I was just struggling with this bug myself!

Copy link
Contributor

mergify bot commented Apr 1, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 5c1caf8 into main Apr 1, 2024
12 checks passed
@mergify mergify bot deleted the overflow-preview branch April 1, 2024 06:32
Copy link
Contributor

mergify bot commented Apr 1, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
2 participants