Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💻 Check for underscore in variable, remove it #5324

Merged
merged 13 commits into from
Mar 29, 2024
Merged

Conversation

Annelein
Copy link
Collaborator

Fixes #4749

How to test

  1. Add for example this code:
continue = ask 'Do you want to continue?'
if continue is yes
    sure = ask 'Are you sure?'
    if sure = yes
        print 'We will continue'
    else
        print 'You are not sure'
else
    print 'You do not want to conintinue'
  1. none of the variables should have an underscore:
Screenshot 2024-03-27 at 14 13 04

@Annelein Annelein marked this pull request as ready for review March 27, 2024 13:17
@Annelein Annelein requested a review from jpelay March 27, 2024 13:17
static/js/debugging.ts Outdated Show resolved Hide resolved
@Felienne
Copy link
Member

Hi @Annelein!

I think the variable is still not showing correctly:

image

Also, can we remove the underscore in the yellow warning bar too?

@Annelein
Copy link
Collaborator Author

Hi @Annelein!

I think the variable is still not showing correctly:

image Also, can we remove the underscore in the yellow warning bar too?

Oh that's weird! It worked for me.. Will look into it.

@Annelein
Copy link
Collaborator Author

@Felienne does it work now?

static/js/debugging.ts Outdated Show resolved Hide resolved
Copy link
Contributor

mergify bot commented Mar 29, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit f5b39c3 into main Mar 29, 2024
12 checks passed
@mergify mergify bot deleted the variable_underscore branch March 29, 2024 11:40
Copy link
Contributor

mergify bot commented Mar 29, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[UI idea] Map reserved keywords back to original in variable view
3 participants