Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪲 fix programs page #5332

Merged
merged 8 commits into from
Apr 2, 2024
Merged

🪲 fix programs page #5332

merged 8 commits into from
Apr 2, 2024

Conversation

hasan-sh
Copy link
Collaborator

@hasan-sh hasan-sh commented Mar 28, 2024

The program overview currently throws an error.
image

This PR fixes it and makes sure that we show a custom adventure's name and not id in the program block.

How to test?

  • run a program/adventure
  • go to my programs
  • it should work.
  • stop the server
  • remove the adventure_name field from that program/adventure's in dev_database > programs > your program
  • re-run the server
  • my programs page should still run fine!

@hasan-sh hasan-sh marked this pull request as ready for review April 2, 2024 15:19
Copy link
Member

@jpelay jpelay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solves the issue!

Copy link
Contributor

mergify bot commented Apr 2, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

1 similar comment
Copy link
Contributor

mergify bot commented Apr 2, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 0f90c91 into main Apr 2, 2024
12 checks passed
@mergify mergify bot deleted the fix-programs-page branch April 2, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants