🚚 Stop normalizing YAML and PO files #5337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our plans to finagle Weblate into committing only once per day to reduce conflicts, allowing us to heavily normalize the translation files, has failed. Weblate is going to commit constantly, and it will have created files with the headers, wrapping, and key ordering that it has decided on its end. Any of our attempts to reformat those files will just lead to merge conflicts. Instead: turn off YAML and POfile formatting; instead what we do to minimize the chances of conflicts is to stop PyBabel from updating PO file headers. Only Weblate is allowed to update those headers.
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our plans to finagle Weblate into committing only once per day to reduce conflicts, allowing us to heavily normalize the translation files, has failed. Weblate is going to commit constantly, and it will have created files with the headers, wrapping, and key ordering that it has decided on its end. Any of our attempts to reformat those files will just lead to merge conflicts.
Instead: turn off YAML and POfile formatting; instead what we do to minimize the chances of conflicts is to stop PyBabel from updating PO file headers. Only Weblate is allowed to update those headers.