-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
💻 New slides #5354
💻 New slides #5354
Conversation
@Annelein remember when we were fixing the code together and talked about the fact that the switcher should change the keywords? I don't see them changing yet! Screencast.from.04-04-24.13.13.11.webm |
Wow I knew there was something I was missing, totally forgot about it, will do it next week! |
@hasan-sh I think this has to do with |
@hasan-sh uuuh what is happening, it's not working anymore? haha |
It is for me! What do you see happening? |
@Annelein i fixed it, probably you meant the tests! It's because |
@hasan-sh I think it is then ready to be reviewed again right? |
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
Fixes #4960
Fixes #4932
Fixes #5056
Let me know if the Achievements part is correct, it is difficult to test and I don't have a lot of experience with them yet.
How to test
/for-teachers
, open a slides level