Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💻 New slides #5354

Merged
merged 31 commits into from
Apr 15, 2024
Merged

💻 New slides #5354

merged 31 commits into from
Apr 15, 2024

Conversation

Annelein
Copy link
Collaborator

@Annelein Annelein commented Apr 2, 2024

Fixes #4960
Fixes #4932
Fixes #5056

Let me know if the Achievements part is correct, it is difficult to test and I don't have a lot of experience with them yet.
How to test

  1. Go to /for-teachers, open a slides level
  2. Run a program for which you would get an achievement and make sure no achievement is shown
  3. Test the language switcher
  4. Test slides look good
Screenshot 2024-04-02 at 15 47 58

@Annelein Annelein marked this pull request as ready for review April 2, 2024 14:56
@Annelein Annelein requested a review from hasan-sh April 3, 2024 12:17
@hasan-sh
Copy link
Collaborator

hasan-sh commented Apr 4, 2024

@Annelein remember when we were fixing the code together and talked about the fact that the switcher should change the keywords? I don't see them changing yet!

Screencast.from.04-04-24.13.13.11.webm

@Annelein
Copy link
Collaborator Author

Annelein commented Apr 4, 2024

@Annelein remember when we were fixing the code together and talked about the fact that the switcher should change the keywords? I don't see them changing yet!

Screencast.from.04-04-24.13.13.11.webm

Wow I knew there was something I was missing, totally forgot about it, will do it next week!

@Annelein
Copy link
Collaborator Author

Annelein commented Apr 8, 2024

@hasan-sh I think this has to do with slide['code'] which is not being updated properly. Could you help me out?

@Annelein
Copy link
Collaborator Author

Annelein commented Apr 9, 2024

@hasan-sh uuuh what is happening, it's not working anymore? haha

@hasan-sh
Copy link
Collaborator

@hasan-sh uuuh what is happening, it's not working anymore? haha

It is for me! What do you see happening?

@hasan-sh
Copy link
Collaborator

@Annelein i fixed it, probably you meant the tests! It's because window.top.reload() was reloading the cypress window when we click on that button.

@Annelein
Copy link
Collaborator Author

@hasan-sh I think it is then ready to be reviewed again right?

Copy link
Contributor

mergify bot commented Apr 15, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 4865878 into main Apr 15, 2024
12 checks passed
@mergify mergify bot deleted the slides branch April 15, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
2 participants