🪲 Embedded editor broken due to missing adventure name

[TiBiBa]

This MR fixes an issue with the embedded editor due to a non-existing adventure object. Adding this check should fix it.

[Felienne]

HI @TiBiBa! I guess this needs to be deployed quickly? 😬 If @jpelay approves I will deploy!

[TiBiBa]

HI @TiBiBa! I guess this needs to be deployed quickly? 😬 If @jpelay approves I will deploy!

Yes, if we could deploy this today that would awesome! Thanks for the quick response, I just tested the fix and it seems to solve the issue. Will prioritize the embedded view testing to prevent this from happening again in the future.

[Felienne]

Deploying now! And yes adding tests will make your own future life less stressful :D

[TiBiBa]

Deploying now! And yes adding tests will make your own future life less stressful :D

Unfortunately it is still not working, is there someway I can verify what code is running on production? The same error still seems to exist. Edit: The last commit is 1acc76. Should this be merged first or can you deploy this PR as well?

[jpelay]

Thanks for fixing it so quickly!

[mergify]

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

[jpelay]

@Felienne I think we need to redeploy? Now that this is merged to main

[TiBiBa]

@Felienne I think we need to redeploy? Now that this is merged to main

Yes I think so too! @jpelay can you deploy or can only @Felienne do this?

[jpelay]

Yes I think so too! @jpelay can you deploy or can only @Felienne do this?

No, she's the only one who can deploy.

[Felienne]

Deploying now! And yes adding tests will make your own future life less stressful :D

Unfortunately it is still not working, is there someway I can verify what code is running on production? The same error still seems to exist. Edit: The last commit is 1acc76. Should this be merged first or can you deploy this PR as well?

Sorry, my bad! Your merge just missed the deploy train because the tests were still running. Now it should be there, can you check again?