-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📜 New tic tac toe adventure #5378
Conversation
The content is done! But it can't be merged before #5398 is fixed. I've also tried making a start with adding the drawing function, like the example from kjansen, which is really cool, but also quite hard. I'm giving up for now, but might contiue later. This is how far I got:
This is kjansens example:
|
Hi @MarleenGilsing! The issue should be fixed now, can you check? Also for the complicated adventure, you/we can also consider to add it as a public adventure? Then people can use if but it won't show up on the tabs right away? (thinking about it, we can move a few more there?) |
The error is gone, so it worked :) Yes, good idea, i like that for the drawing adventure, because it's too complicated to add as a normal adventure. I'll turn that into a seperate issue. So this can be closed. |
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
This is the draft for the new Tic Tac Toe adventure. I haven't had a change to test it myself yet, as my local host stopped working for some unknown reason, so I'll test it next week.
The level 16 content should work fine. For the level 17 content I came across I problem I didn't understand. @Felienne I've sent you this problem on discord. Do you know what's wrong? This is the code that I think should work, but doesn't.
This extremely simplified version does work, so I think the problem lies with me:
EDIT: did another test and changed field[1], field[2] and field[3] to a, b and c. This also works. Still don't quite know why. But this might be helpful.
If we can get it to work, I'll test it next week and I'll add it to the other languages and translate it to Dutch.
PS. The tests will definitely be mad, because I removed some levels from the old toc tac toe adventure in english, but they are still there in the other languages. So that's no problem.