-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🧹 Replace 403 by 401 in some occurences #5394
Conversation
…into replace-403-by-401
|
Pinging @TiBiBa (or otherwise maybe @rix0rrr or @jpelay here) I did not make this issue and I am not really an expert in this actually :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Annelein I commented on each case that I saw a comment of yours, hope it helped!
I think that it's fine to have some more descriptive error messages than just a generic one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
Fixes #3634
How to test
Not really possible I think, but all unit tests should pass of course.