Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧪 Test a few broken programs from the front-end #5421

Merged
merged 9 commits into from
Apr 17, 2024
Merged

Conversation

Annelein
Copy link
Collaborator

Fixes #4405

How to test
Cypress tests should pass

Copy link
Member

@jpelay jpelay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi annelein, good work! I think this will be enough to test the error-box modal. I suggested a few changes with respect to waiting for the server to parse the errors.

tests/cypress/e2e/hedy_page/invalid_program.cy.js Outdated Show resolved Hide resolved
tests/cypress/e2e/hedy_page/invalid_program.cy.js Outdated Show resolved Hide resolved
@Annelein
Copy link
Collaborator Author

@jpelay thanks! just added your suggestions

@Annelein Annelein requested a review from jpelay April 17, 2024 12:27
Copy link
Member

@jpelay jpelay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!!!

Copy link
Contributor

mergify bot commented Apr 17, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 0a088e1 into main Apr 17, 2024
12 checks passed
@mergify mergify bot deleted the error-tests branch April 17, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[TESTING] Test a few broken programs from the front-end
2 participants