Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💻 Option to hide explore page in customize class #5453

Merged
merged 6 commits into from
Apr 22, 2024
Merged

Conversation

Annelein
Copy link
Collaborator

@Annelein Annelein commented Apr 22, 2024

Fixes #5427

How to test

  1. Log in as a teacher
  2. Go to for-teachers
  3. Go to customize class of a class with students
  4. Select 'Disable explore page'
  5. Log in as a student of that class
  6. See if the Explore page is hidden
Screenshot 2024-04-22 at 16 24 58

@Annelein Annelein marked this pull request as draft April 22, 2024 14:32
@Annelein Annelein marked this pull request as ready for review April 22, 2024 15:03
Copy link
Member

@jpelay jpelay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

cy.wait('@updateCustomizations').should('have.nested.property', 'response.statusCode', 200);
loginForStudent();
cy.get("#explorebutton").should("not.exist")
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for adding a test!!

Copy link
Contributor

mergify bot commented Apr 22, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 65ee552 into main Apr 22, 2024
12 checks passed
@mergify mergify bot deleted the hide-explore branch April 22, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

💻 Allow teachers to disable explore page
2 participants