Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💻 Guest teacher connect option in teacher signup #5467

Merged
merged 11 commits into from
Apr 30, 2024
Merged

💻 Guest teacher connect option in teacher signup #5467

merged 11 commits into from
Apr 30, 2024

Conversation

Annelein
Copy link
Collaborator

Fixes #5428

How to test

  1. Go to the sign up page for teachers
  2. Check the checkbox for connecting to a guest teacher
  3. Make sure the phone number field pops up
  4. Make sure only numbers are allowed in this field, not text.
Screenshot 2024-04-24 at 15 05 58

@Annelein Annelein marked this pull request as ready for review April 24, 2024 13:35
@Annelein
Copy link
Collaborator Author

Creating an account without selecting 'connect with a guest teacher', doesn't work anymore, because the phone input field is hidden but still required... I'm not sure how to solve this. If anyone could help me out, that would be great.

hasan-sh
hasan-sh reviewed Apr 29, 2024
View reviewed changes
Copy link
Collaborator

@hasan-sh hasan-sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This way you only make it required when it's in use!

templates/signup.html Outdated Show resolved Hide resolved
templates/signup.html Outdated Show resolved Hide resolved
@Annelein Annelein requested a review from hasan-sh April 29, 2024 15:28
hasan-sh
hasan-sh approved these changes Apr 30, 2024
View reviewed changes
Copy link
Collaborator

@hasan-sh hasan-sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to add!

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 30, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 30, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 08bfde4 into main Apr 30, 2024
12 checks passed
@mergify mergify bot deleted the guest-teacher-connect branch April 30, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasan-sh hasan-sh hasan-sh approved these changes

Assignees

@hasan-sh hasan-sh

Labels
under-review
Projects
Hedy organization board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

💻 Two new fields in the sign up page for teachers
3 participants
@Annelein @hasan-sh @jpelay