🪲 Fix Syntax Highlighting Issue for Special Characters in Level 2 #5480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoseArtur
force-pushed
the
special_char_highlight
branch
3 times, most recently
from
dd460a8
to
e1f7526
Compare
JoseArtur
force-pushed
the
special_char_highlight
branch
from
011118b
to
dd934ab
Compare
Felienne
approved these changes
Apr 29, 2024
There was a problem hiding this comment.
Hola @JoseArtur!
Thanks for your first PR and welcome to Hedy!!
I can confirm this solves the issue:
|
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
|
Hi @Felienne . |
|
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a syntax highlighting issue in Level 2.
Previously, if an exclamation mark followed a variable, it was still considered valid, but the syntax highlighter did not reflect this correctly.
For instance, in the command:
name is Hedy print name is nameThe keyword name was highlighted in blue in all occurrences. However, if an exclamation mark was added to the end of the command:
name is Hedy print name is name!The keyword name was only highlighted in blue in the first occurrence.
To resolve this issue, I have introduced a SpecialChar token to the grammar file.
This token includes an exclamation mark (!), question mark (?), and period (.) characters.
With this change, the syntax highlighter correctly recognizes and highlights the variable name even when a special character follows it.
Fixes #5089
How to test
Follow these steps to verify this PR works as intended: