Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💻 Allow HTML mode in wysiwyg editor #5497

Merged
merged 3 commits into from
May 6, 2024

Conversation

hasan-sh
Copy link
Collaborator

@hasan-sh hasan-sh commented May 1, 2024

Fixes #5491
Fixes #5437

How to test?

  • customize an adventure and add some html
  • preview that adventure from the for-teacher page to see how it's rendered.

Copy link
Member

@jpelay jpelay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work!

image

Copy link
Contributor

mergify bot commented May 6, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

Copy link
Contributor

mergify bot commented May 6, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 7b0d714 into main May 6, 2024
12 checks passed
@mergify mergify bot deleted the adventure-editor-html-integration branch May 6, 2024 19:51
@Felienne
Copy link
Member

Felienne commented May 8, 2024

Thanks @hasan-sh! Can you tell the teacher who coined this on Discord that this works (again)?

@Felienne
Copy link
Member

Felienne commented May 8, 2024

(put it on ToBeDiscussed so we don't forget to notify the teacher!)

@hasan-sh hasan-sh self-assigned this May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

💻 Allow HTML mode in wysiwyg editor 💻 markup and images in custom adventures
3 participants