Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🪲 correctly remove adventure from adventrues table #5505

Merged
merged 2 commits into from
May 7, 2024
Merged

🪲 correctly remove adventure from adventrues table #5505

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5abc0b2
specify that htmx should swap the content
hasan-sh May 7, 2024
b11cdfd
check adventures table exist after deleting an adventure
hasan-sh May 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion templates/htmx-adventures-table.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,8 @@ <h2 class="m-0 justify-left"> {{_('my_adventures')}} </h2>
hx-confirm="{{_('delete_adventure_prompt')}}"
hx-trigger="click"
hx-delete="/for-teachers/customize-adventure/{{adventure.id}}"
hx-target="#adventures_table">
hx-target="#adventures_table"
hx-swap="outerHTML">
<span class="fas fa-trash block mb-1 text-red-700"></span>
<span class="text-red-700">{{_('remove')}}</span>
</button>
Expand Down
2 changes: 2 additions & 0 deletions tests/cypress/e2e/tools/adventures/adventure.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ export function deleteAdventure(name) {
}
})
cy.get('[data-cy="modal_yes_button"]').should('be.enabled').click();
cy.get("#adventures_table")
.should("be.visible");
}

export default {createAdventure};
Loading