Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧪 Update test db #5539

Merged
merged 6 commits into from
Jun 4, 2024
Merged

🧪 Update test db #5539

merged 6 commits into from
Jun 4, 2024

Conversation

Annelein
Copy link
Collaborator

Fixes #5522

How to test
See if teacher1 now has programs and a public profile

@Annelein
Copy link
Collaborator Author

@Felienne this test fails: second-teachers can NOT view each other's public programs because teacher1 now has public programs and teacher4 can actually see them. So I don't think this was a properly working test before?

But did we change this, are second teachers allowed to view each other's public programs now? Or does this PR catch an issue?

@Felienne
Copy link
Member

@Felienne this test fails: second-teachers can NOT view each other's public programs because teacher1 now has public programs and teacher4 can actually see them. So I don't think this was a properly working test before?

Ah good find!! The immediate effects of more test data :)

But did we change this, are second teachers allowed to view each other's public programs now? Or does this PR catch an issue?

I don't think this change was intentional, but maybe @jpelay or @hasan-sh knows?

@hasan-sh
Copy link
Collaborator

hasan-sh commented May 28, 2024

@Felienne this test fails: second-teachers can NOT view each other's public programs because teacher1 now has public programs and teacher4 can actually see them. So I don't think this was a properly working test before?

This test isn't failing on master and passing as expected, but i see you added two public programs, not sure why, but then you need to adjust the tests accordingly. For instance, https://github.com/hedyorg/hedy/blob/main/tests/cypress/e2e/public_programs/programs_page.cy.js#L141 wouldn't hold anymore!

But did we change this, are second teachers allowed to view each other's public programs now? Or does this PR catch an issue?

Second teachers can do different things; see here #4644

@Annelein Annelein requested a review from hasan-sh May 30, 2024 13:38
@Annelein Annelein requested a review from hasan-sh May 31, 2024 15:25
Copy link
Contributor

mergify bot commented Jun 4, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 18f7a76 into main Jun 4, 2024
12 checks passed
@mergify mergify bot deleted the update-test-db branch June 4, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add saved programs in test DB
3 participants