-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🧪 Update test db #5539
🧪 Update test db #5539
Conversation
@Felienne this test fails: But did we change this, are second teachers allowed to view each other's public programs now? Or does this PR catch an issue? |
Ah good find!! The immediate effects of more test data :)
I don't think this change was intentional, but maybe @jpelay or @hasan-sh knows? |
This test isn't failing on master and passing as expected, but i see you added two public programs, not sure why, but then you need to adjust the tests accordingly. For instance, https://github.com/hedyorg/hedy/blob/main/tests/cypress/e2e/public_programs/programs_page.cy.js#L141 wouldn't hold anymore!
Second teachers can do different things; see here #4644 |
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
Fixes #5522
How to test
See if teacher1 now has programs and a public profile