Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪲 Broken boolean translation #5574

Merged
merged 11 commits into from
May 29, 2024
Merged

🪲 Broken boolean translation #5574

merged 11 commits into from
May 29, 2024

Conversation

boryanagoncharenko
Copy link
Collaborator

Fixes #5572
Fixes tests failing due to boolean translation

How to test

  1. Ensure that tests are failing: checkout the main branch, comment out the code in snippet_already_tested_with_current_hedy_version and make it always return False, run the tests test_level_15.py and note that tests are failing.
  2. To check that the error are fixed: checkout the boolean_translation_5572 branch, again make the snippet_already_tested_with_current_hedy_version always return False and run all tests, ensure that they are all successful.

Copy link
Member

@jpelay jpelay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

Copy link
Contributor

mergify bot commented May 28, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

Copy link
Contributor

mergify bot commented May 29, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 19ad330 into main May 29, 2024
12 checks passed
@mergify mergify bot deleted the broken_boolean_translation_5572 branch May 29, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

🪲 Translation of booleans cause unit tests to fail
3 participants